Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix worker paths and add missing filename #134

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

MonicaOlejniczak
Copy link
Contributor

Motivation

When migrating to TypeScript, all of the worker paths break due to the change in extension. Additionally, the babel dependency in the eslint plugin changes slightly and requires a filename in the tests.

Changes

  • Resolve worker paths without an extension
  • Use a public export name for the worker paths using the development condition
  • Add filename to eslint parser

Checklist

  • Existing or new tests cover this change

@MonicaOlejniczak MonicaOlejniczak requested a review from a team October 18, 2024 00:04
Copy link
Contributor

@yamadapc yamadapc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@MonicaOlejniczak MonicaOlejniczak merged commit fb58d07 into main Oct 18, 2024
23 checks passed
@MonicaOlejniczak MonicaOlejniczak deleted the monica/ts-fixes branch October 18, 2024 04:22
Nikola-3 pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants