-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the website to document the end-to-end lifecycle of Compiled #1738
Conversation
|
✅ Deploy Preview for compiled-css-in-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was used on https://compiledcssinjs.com/docs/api-css-prop, I feel it was fine to update it to be a bit more succinct and share it elsewhere.
@@ -1,105 +1,36 @@ | |||
import { ExampleContainer, ExampleRoot } from '@compiled/website-ui'; | |||
import { LargeText } from '../components/example'; | |||
|
|||
## Don't change a thing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do kinda want people to change a few things now 😄
Thanks @kylorhall-atlassian! |
A bit late - but I approve! This is a wonderful change. I've messaged you some opportunities to further build on the great work you have done 🫡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What is this change?
I'm updating the documentation on https://compiledcssinjs.com from internal feedback around the Compiled work as people are questioning and need to understand the differences between runtime and extraction.
Very open to feedback! It just seemed like the content on the homepage was quite important, but even I've never read it! Moving it to
/docs/how-it-works
might help that.I did remove a few scenarios around dynamic styles, eg. the
style={{ '--abcde': props.color }}
pattern, but I think it's documented elsewhere and it's best to keep it simple.PR checklist
website/