Apply suggestions from code review

Co-authored-by: Franklin Wang <[email protected]>
atlassian-labs · Oct 9, 2023 · 9eeb347 · 9eeb347
1 parent e3ff70e
commit 9eeb347
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 18 deletions.
diff --git a/lib/src/main/java/graphql/nadel/engine/blueprint/hydration/NadelHydrationActorInputDef.kt b/lib/src/main/java/graphql/nadel/engine/blueprint/hydration/NadelHydrationActorInputDef.kt
@@ -51,17 +51,16 @@ data class NadelHydrationActorInputDef(
          *
          * ```graphql
          * type Issue {
-         *   id: ID! # Value used as argument to issueId
+         *   id: ID!
          *   owner: User @hydrated(from: ["issueOwner"], args: [
          *      {name: "issueId" value: "issue123"}
          *   ])
          * }
          * ```
          */
-        data class StaticValue (
+        data class StaticValue(
             val value: Value<*>,
-        ): ValueSource()
-
+        ) : ValueSource()
     }
 }
 
diff --git a/lib/src/main/java/graphql/nadel/engine/transform/hydration/NadelHydrationInputBuilder.kt b/lib/src/main/java/graphql/nadel/engine/transform/hydration/NadelHydrationInputBuilder.kt
@@ -1,7 +1,6 @@
 package graphql.nadel.engine.transform.hydration
 
 import graphql.language.NullValue
-import graphql.language.StringValue
 import graphql.language.Value
 import graphql.nadel.engine.blueprint.NadelHydrationFieldInstruction
 import graphql.nadel.engine.blueprint.hydration.NadelHydrationActorInputDef

diff --git a/...in/java/graphql/nadel/engine/transform/hydration/batch/NadelBatchHydrationInputBuilder.kt b/...in/java/graphql/nadel/engine/transform/hydration/batch/NadelBatchHydrationInputBuilder.kt
@@ -63,7 +63,7 @@ internal object NadelBatchHydrationInputBuilder {
                         actorFieldArg to staticValue
                     }
                 }
-            }
+            },
         )
     }
 

diff --git a/lib/src/main/java/graphql/nadel/schema/NadelDirectives.kt b/lib/src/main/java/graphql/nadel/schema/NadelDirectives.kt
@@ -366,7 +366,7 @@ object NadelDirectives {
     }
 
     private fun createRemoteArgumentSource(value: Value<*>): RemoteArgumentSource {
-        if (value  is StringValue) {
+        if (value is StringValue) {
             val values = listFromDottedString(value.value)
             return when (values.first()) {
                 "\$source" -> RemoteArgumentSource(
@@ -383,22 +383,20 @@ object NadelDirectives {
                     sourceType = SourceType.FieldArgument,
                 )
 
-                else ->
-                    RemoteArgumentSource(
-                        argumentName = null,
-                        pathToField = null,
-                        staticValue = value,
-                        sourceType = SourceType.StaticArgument,
-                        )
+                else -> RemoteArgumentSource(
+                    argumentName = null,
+                    pathToField = null,
+                    staticValue = value,
+                    sourceType = SourceType.StaticArgument,
+                )
             }
-        }
-        else {
+        } else {
             return RemoteArgumentSource(
                 argumentName = null,
                 pathToField = null,
                 staticValue = value,
                 sourceType = SourceType.StaticArgument,
-                )
+            )
         }
     }
 

diff --git a/lib/src/main/java/graphql/nadel/schema/NeverWiringFactory.kt b/lib/src/main/java/graphql/nadel/schema/NeverWiringFactory.kt
@@ -25,7 +25,7 @@ open class NeverWiringFactory : WiringFactory {
 
     override fun getScalar(environment: ScalarWiringEnvironment): GraphQLScalarType? {
         val scalarName = environment.scalarTypeDefinition.name
-        if (scalarName == ExtendedScalars.Json.name){
+        if (scalarName == ExtendedScalars.Json.name) {
             return ExtendedScalars.Json
         }
         return GraphQLScalarType