Skip to content

Commit

Permalink
Let's sunset this behavior, it introduces complexity without consumers
Browse files Browse the repository at this point in the history
  • Loading branch information
gnawf committed Jul 30, 2024
1 parent a60df18 commit a129818
Showing 1 changed file with 0 additions and 44 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -474,50 +474,6 @@ class NadelTypeValidationTest : DescribeSpec({
assert(error.overallField.name == "nextgenSpecific")
}

it("ignores extension union members declared by other services") {
val fixture = NadelValidationTestFixture(
overallSchema = mapOf(
"users" to """
type Query {
stuff: Stuff
}
union Stuff = User
type User {
id: ID!
}
""".trimIndent(),
"issues" to """
extend union Stuff = | Issue
type Issue {
id: ID!
}
""".trimIndent(),
),
underlyingSchema = mapOf(
"users" to """
type Query {
stuff: Stuff
}
union Stuff = User
type User {
id: ID!
}
""".trimIndent(),
"issues" to """
type Query {
echo: String
}
type Issue {
id: ID!
}
""".trimIndent(),
),
)

val errors = validate(fixture)
assert(errors.map { it.message }.isEmpty())
}

it("validates extension union member if defined by own service") {
val fixture = NadelValidationTestFixture(
overallSchema = mapOf(
Expand Down

0 comments on commit a129818

Please sign in to comment.