Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding When condition input types #474

Merged
merged 6 commits into from
Dec 6, 2023
Merged

Adding When condition input types #474

merged 6 commits into from
Dec 6, 2023

Conversation

sbarker2
Copy link
Collaborator

@sbarker2 sbarker2 commented Nov 8, 2023

Please make sure you consider the following:

  • Add tests that use __typename in queries
  • Does this change work with all nadel transformations (rename, type rename, hydration, etc)? Add tests for this.
  • Is it worth using hints for this change in order to be able to enable a percentage rollout?
  • Do we need to add integration tests for this change in the graphql gateway?
  • Do we need a pollinator check for this?

gnawf
gnawf requested changes Nov 13, 2023
View reviewed changes
lib/src/main/java/graphql/nadel/schema/NadelDirectives.kt Outdated Show resolved Hide resolved
lib/src/main/java/graphql/nadel/schema/NadelDirectives.kt Outdated Show resolved Hide resolved
lib/src/main/java/graphql/nadel/schema/NadelDirectives.kt Outdated Show resolved Hide resolved
lib/src/main/java/graphql/nadel/schema/NadelDirectives.kt Outdated Show resolved Hide resolved
lib/src/main/java/graphql/nadel/schema/NadelDirectives.kt Outdated Show resolved Hide resolved
lib/src/main/java/graphql/nadel/schema/NadelDirectives.kt Outdated Show resolved Hide resolved
lib/src/main/java/graphql/nadel/schema/NadelDirectives.kt Outdated Show resolved Hide resolved
lib/src/main/java/graphql/nadel/schema/NadelDirectives.kt Outdated Show resolved Hide resolved
lib/src/main/java/graphql/nadel/schema/NadelDirectives.kt Outdated Show resolved Hide resolved
@sbarker2 sbarker2 requested a review from gnawf November 19, 2023 22:21
@sbarker2 sbarker2 self-assigned this Dec 5, 2023
@sbarker2 sbarker2 merged commit 79c58b5 into master Dec 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnawf gnawf gnawf approved these changes

Assignees

@sbarker2 sbarker2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbarker2 @gnawf