Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch hydration that works per source ID than per source object #479

Merged
merged 6 commits into from
Dec 14, 2023
Merged

Batch hydration that works per source ID than per source object #479

merged 6 commits into from
Dec 14, 2023

Conversation

gnawf
Copy link
Collaborator

@gnawf gnawf commented Dec 6, 2023

Please make sure you consider the following:

  • Add tests that use __typename in queries
  • Does this change work with all nadel transformations (rename, type rename, hydration, etc)? Add tests for this.
  • Is it worth using hints for this change in order to be able to enable a percentage rollout?
  • Do we need to add integration tests for this change in the graphql gateway?
  • Do we need a pollinator check for this?

@gnawf gnawf changed the title Multi ati polymorphic hydration Batch hydration that works per source ID than per source objecgt Dec 6, 2023
@gnawf gnawf changed the title Batch hydration that works per source ID than per source objecgt Batch hydration that works per source ID than per source object Dec 6, 2023
Base automatically changed from fork-tests to master December 10, 2023 22:09
@gnawf gnawf force-pushed the multi-ati-polymorphic-hydration branch 2 times, most recently from b9f100e to 5de3752 Compare December 10, 2023 23:03
@gnawf gnawf mentioned this pull request Dec 10, 2023
Merged
@gnawf gnawf force-pushed the multi-ati-polymorphic-hydration branch from 5de3752 to 35f0f8c Compare December 10, 2023 23:24
@gnawf gnawf merged commit d7db5e5 into master Dec 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbarker2 sbarker2 sbarker2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnawf @sbarker2