Index hydration partitioned source ids #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawf
force-pushed
the
index-hydration-partitioned-source-ids
branch
2 times, most recently
from
564e126
to
365410f
Compare
gnawf
force-pushed
the
index-hydration-partitioned-source-ids
branch
from
365410f
to
af4687d
Compare
gnawf
commented
Dec 18, 2023
| @@ -27,22 +51,28 @@ internal object NadelNewBatchHydrationInputBuilder { | |||
| instruction: NadelBatchHydrationFieldInstruction, | |||
| hydrationField: ExecutableNormalizedField, | |||
| sourceIds: List<JsonNode>, | |||
| ): List<Map<NadelHydrationActorInputDef, NormalizedInputValue>> { | |||
| ): List<NadelHydrationArgumentsBatch> { | |||
There was a problem hiding this comment.
Created an object to store the original type + the sourceIds that made up the batch.
| sourceIds = chunk | ||
| .map { | ||
| JsonNode(it) | ||
| }, |
There was a problem hiding this comment.
This returns the source IDs used to create this batch.
sbarker2
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #482