List defer hydrations #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawf
force-pushed
the
list-defer-hydrations
branch
from
026cd09
to
a3c9a16
Compare
gnawf
force-pushed
the
list-defer-hydrations
branch
from
a3c9a16
to
c0dff0c
Compare
gnawf
force-pushed
the
list-defer-hydrations
branch
from
c0dff0c
to
48024c2
Compare
Merged
gnawf
force-pushed
the
list-defer-hydrations
branch
2 times, most recently
from
a022391
to
abd7ab9
Compare
gnawf
force-pushed
the
list-defer-hydrations
branch
from
abd7ab9
to
4a25cf0
Compare
gnawf
force-pushed
the
list-defer-hydrations
branch
from
4a25cf0
to
ec9770e
Compare
gnawf
force-pushed
the
list-defer-hydrations
branch
from
ec9770e
to
8baef70
Compare
gnawf
force-pushed
the
list-defer-hydrations
branch
3 times, most recently
from
1c40129
to
15c9cf0
Compare
gnawf
force-pushed
the
list-defer-hydrations
branch
2 times, most recently
from
120d1e7
to
40640d1
Compare
felipe-gdr
reviewed
May 29, 2024
lib/src/main/java/graphql/nadel/engine/transform/result/json/JsonNodes.kt
Outdated
Show resolved
Hide resolved
lib/src/main/java/graphql/nadel/engine/transform/result/json/NadelJsonNodeIterator.kt
Outdated
Show resolved
Hide resolved
| abstract val value: Any? | ||
|
|
||
| companion object { | ||
| operator fun NadelEphemeralJsonNode.component1(): List<String> = queryPath |
There was a problem hiding this comment.
TIL: about Kotlin destructuring declarations https://kotlinlang.org/docs/destructuring-declarations.html
lib/src/main/java/graphql/nadel/engine/transform/result/json/NadelJsonNodeIterator.kt
Outdated
Show resolved
Hide resolved
gnawf
force-pushed
the
list-defer-hydrations
branch
from
a760227
to
f977637
Compare
felipe-gdr
reviewed
Jul 31, 2024
lib/src/main/java/graphql/nadel/engine/transform/hydration/NadelHydrationTransform.kt
Outdated
Show resolved
Hide resolved
felipe-gdr
previously approved these changes
Jul 31, 2024
gnawf
force-pushed
the
list-defer-hydrations
branch
from
e814ee2
to
073fcaf
Compare
felipe-gdr
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.