[WIP] Add deferred executions to rename transform #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-rename-transform
…to-rename-transform
* nextgen engine changes for defer * adding defer tests * adding more stuff to defer tests * Ignore failing tests (defer queries with multiple service call) * ignore location field in defer test errors (#554) * fix error locations bug (#555) * changing defer tests * remove @ignore on previously failing tests * update test snapshots * cleaning up defer tests
* Bump GraphQL Java Should pull in Fix builder return type and expose generic toSpecification #3642 graphql-java/graphql-java#3642 * Fix build * Fix test expected errors
* Add individual update snapshot functions * Update tests * Make private
# Conflicts: # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/ComprehensiveDeferQueryWithDifferentServiceCallsSnapshot.kt # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/DeferOnListItemsTestSnapshot.kt # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/DeferThrowsErrorTestSnapshot.kt # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/DeferWithIfFalseTestSnapshot.kt # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/DeferWithLabelTestSnapshot.kt # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/DeferWithoutLabelTestSnapshot.kt # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/MultipleDeferDirectivesTestSnapshot.kt # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/MultipleDeferWithDifferentServiceCalls.kt # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/MultipleDeferWithDifferentServiceCallsSnapshot.kt # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/MultipleFieldsinMultipleDeferDirectivesTestSnapshot.kt # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/MultipleFieldsinSingleDeferDirectiveTestSnapshot.kt # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/NestedDefersTest.kt # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/NestedDefersTestSnapshot.kt
* Enable union validation * Add more tests around omitted union members * Let's sunset this behavior, it introduces complexity without consumers * Add unit tests for union validation * Wording * More tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding deferred executions to the rename transformer (it previously would ignore
@deferdirectives