-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer payloads in groups #562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawf
force-pushed
the
defer-payloads-in-groups
branch
2 times, most recently
from
July 30, 2024 05:25
ad4f8ac
to
334199f
Compare
felipe-gdr
reviewed
Jul 31, 2024
import graphql.normalized.ExecutableNormalizedOperation | ||
import graphql.normalized.incremental.NormalizedDeferredExecution | ||
|
||
class NadelIncrementalResultAccumulator( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some docs on this class that briefly describes the problem that it is solving?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
gnawf
force-pushed
the
defer-payloads-in-groups
branch
from
August 7, 2024 04:33
334199f
to
8b9c2a8
Compare
gnawf
force-pushed
the
defer-payloads-in-groups
branch
from
August 7, 2024 04:36
8b9c2a8
to
be50be1
Compare
gnawf
force-pushed
the
defer-payloads-in-groups
branch
from
August 7, 2024 04:36
be50be1
to
9f0c3c4
Compare
felipe-gdr
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early work