Enable union validation #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawf
commented
Jul 30, 2024
| @@ -22,7 +22,7 @@ overallSchema: | |||
| # language=GraphQL | |||
| underlyingSchema: | |||
| Issues: | | |||
| union HasName = Issue | Edible | |||
| union HasName = Issue | Edible | Troll | User | |||
There was a problem hiding this comment.
Honestly not sure why these tests are set up like this… this is not desirable behavior.
There was a problem hiding this comment.
Shall we remove them or replace them with new tests using the new format?
There was a problem hiding this comment.
I think I'll just leave them, just not sure why the overall schema had more members to begin with…
felipe-gdr
reviewed
Jul 30, 2024
| @@ -474,50 +474,6 @@ class NadelTypeValidationTest : DescribeSpec({ | |||
| assert(error.overallField.name == "nextgenSpecific") | |||
| } | |||
|
|
|||
| it("ignores extension union members declared by other services") { | |||
There was a problem hiding this comment.
Can we add tests for the checks performed by NadelUnionValidation?
There was a problem hiding this comment.
Yeah my bad, got distracted by E2E tests and forgot. Will add some.
There was a problem hiding this comment.
Good stuff!!! Thanks for that.
felipe-gdr
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly not quite sure why this was commented out… running this on central schema seems fine.