Fix delayed result snapshot #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawf
commented
Aug 29, 2024
| @@ -55,7 +55,8 @@ public class DeferredFieldIsRenamedTestSnapshot : TestSnapshot() { | |||
| | "defer" | |||
| | ], | |||
| | "data": { | |||
| | "overallString": "string for the deferred renamed field" | |||
There was a problem hiding this comment.
Because we didn't clone the result before Nadel mutated it, the test snapshots wrote down the final result that already had the field renamed.
felipe-gdr
previously approved these changes
Aug 29, 2024
gnawf
force-pushed
the
fix-delayed-result-snapshot
branch
from
b524e73
to
a79f60e
Compare
gnawf
changed the base branch from
apply-transforms-to-defer-payloads
to
master
|
Hey @felipe-gdr had to push to add more fixes to tests introduced in #586 |
sbarker2
approved these changes
Sep 3, 2024
felipe-gdr
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test snapshots were wrong because we weren't deep cloning the result before Nadel mutated it.
Pending #579