Move partition instruction to Blueprint #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipe-gdr
commented
Oct 21, 2024
| // We can't partition a field that has multiple partition instructions in different types | ||
| if (partitionInstructions.size != 1) { | ||
| // TODO add validation to ensure @partition is not used in a way that would result in a ENF to have multiple partition instructions | ||
| return null |
There was a problem hiding this comment.
another improvement introduced in this PR: don't call getFieldPartitionContext for fields that don't have @partition
gnawf
approved these changes
Oct 21, 2024
| location = makeFieldCoordinates(parentType, field), | ||
| pathToPartitionArg = partitionDefinition.pathToSplitPoint, | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Shouldn't this store more info like whether the output type is Payload like? etc.
Though maybe leave the changes here minimal because I'm exploring merging validation & blueprint code together in another branch.
There was a problem hiding this comment.
True. All this static information should live in the Blueprint.
I'll wait for your refactor to make the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 benefits out of this:
overallField.getFieldDefinitions()calls in the transform, which can cause problems when used in conjunction with hydrations and renames