Handle undefined in removeQueryParams

atlassian-labs · Nov 14, 2022 · e88eca9 · e88eca9
1 parent 8c07764
commit e88eca9
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 4 deletions.
diff --git a/packages/plugins/babel/src/utils.ts b/packages/plugins/babel/src/utils.ts
@@ -15,10 +15,14 @@ function addDotSlashPrefix(path: string): string {
   return hasRelativePrefix(path) ? path : `./${path}`;
 }
 
-function removeQueryParams(input: string) {
+function removeQueryParams(input: string | undefined) {
   // When resolving a package with `exports` in the package.json, `enhanced-resolve` will fail
   // match if the import contains a query string. Query strings could be used to pass import
   // meta data in some cases (e.g. Parcel with support for "magic comments")
+  if (!input) {
+    return input;
+  }
+
   const qsPos = input.indexOf('?');
 
   if (qsPos !== -1) {

diff --git a/packages/plugins/parcel-reporter-manifest/src/utils.ts b/packages/plugins/parcel-reporter-manifest/src/utils.ts
@@ -13,10 +13,14 @@ const getAssetId = (basePath: string, assetPath: string) => {
   return assetId;
 };
 
-const removeQueryParams = (input: string) => {
+const removeQueryParams = (input: string | undefined) => {
   // When resolving a package with `exports` in the package.json, `enhanced-resolve` will fail
   // match if the import contains a query string. Query strings could be used to pass import
   // meta data in some cases (e.g. Parcel with support for "magic comments")
+  if (!input) {
+    return input;
+  }
+
   const qsPos = input.indexOf('?');
 
   if (qsPos !== -1) {

diff --git a/packages/plugins/parcel-transformer/src/utils.ts b/packages/plugins/parcel-transformer/src/utils.ts
@@ -86,10 +86,14 @@ export const findUsages = (code: string, importSpecifiers: Set<string>) => {
   return usages;
 };
 
-const removeQueryParams = (input: string) => {
+const removeQueryParams = (input: string | undefined) => {
   // When resolving a package with `exports` in the package.json, `enhanced-resolve` will fail
   // match if the import contains a query string. Query strings could be used to pass import
   // meta data in some cases (e.g. Parcel with support for "magic comments")
+  if (!input) {
+    return input;
+  }
+
   const qsPos = input.indexOf('?');
 
   if (qsPos !== -1) {

diff --git a/packages/plugins/webpack/src/utils.ts b/packages/plugins/webpack/src/utils.ts
@@ -117,10 +117,14 @@ export const buildManifest = (
   );
 };
 
-export const removeQueryParams = (input: string) => {
+export const removeQueryParams = (input: string | undefined) => {
   // When resolving a package with `exports` in the package.json, `enhanced-resolve` will fail
   // match if the import contains a query string. Query strings could be used to pass import
   // meta data in some cases (e.g. Parcel with support for "magic comments")
+  if (!input) {
+    return input;
+  }
+
   const qsPos = input.indexOf('?');
 
   if (qsPos !== -1) {