Use TaskScope #183
Merged
Use TaskScope #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove usages of `TaskTimer`. Remove usages of `CloseableThreadContext`. Move some operations under the appropriate task. Plan to replace `facilitateSsh` (from `aws-resources`) with a new method on `Ssh.publishLoginEvents()` (in `ssh`), which should use `EventBus`.
They can be used to describe or use EC2 instances in a given context (e.g. this is the EC2 node details for VU node).
src/test/kotlin/com/atlassian/performance/tools/awsinfrastructure/LogConfiguration.kt
Show resolved
Hide resolved
mgrzaslewicz
approved these changes
Jan 2, 2024
dagguh
added a commit
that referenced
this pull request
Jan 2, 2024
Merged
dagguh
added a commit
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bypassing the
TaskScope, we ended up as having insufficient metadata, which ended up as "unknown" tasks in GUI.Before:
After:
