Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark 3.1.6 + bump via CI #189

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Mark 3.1.6 + bump via CI #189

merged 3 commits into from
Jun 12, 2024

Conversation

dagguh
Copy link
Contributor

@dagguh dagguh commented Jun 12, 2024

Yes, I made the same mistake twice in a row.
Gonna fix that in the next commit.

I made too many mistakes when bumping it manually via git tag.
Inspired by atlassian-labs/db-replica@4f79ab2

Before:

  • git tag the appropriate commit
    • the one rebased by GitHub, not your local pre-pull-request commit
    • construct the tag name by hand, e.g. release-3.2.0-alpha minor bump
  • git push the tag
  • trigger GitHub Actions with "yes"

After:

  • pick the bump type in GitHub actions
  • trigger GitHub Actions with the bump type, e.g. "Minor"

https://packages.atlassian.com/maven-central/com/atlassian/performance/tools/aws-infrastructure/3.1.6/

Yes, I made the same mistake twice in a row.
Gonna fix that in the next commit.
@dagguh dagguh requested a review from a team as a code owner June 12, 2024 15:01
I made too many mistakes when bumping it manually via `git tag`.
Inspired by atlassian-labs/db-replica@4f79ab2

Before:
- `git tag` the appropriate commit
  - the one rebased by GitHub, not your local pre-pull-request commit
  - construct the tag name by hand, e.g. `release-3.2.0-alpha` minor bump
- `git push` the tag
- trigger GitHub Actions with "yes"

After:
- pick the bump type in GitHub actions
- trigger GitHub Actions with the bump type, e.g. "Minor"
@dagguh
Copy link
Contributor Author

dagguh commented Jun 12, 2024

Currently looks like this:
image
Apparently, No got translated to false, thanks YAML 😁

I didn't want a `false`.
@dagguh
Copy link
Contributor Author

dagguh commented Jun 12, 2024

Before:
image

After:
image

@dagguh dagguh enabled auto-merge (rebase) June 12, 2024 15:15
@dagguh dagguh merged commit db12b6f into master Jun 12, 2024
4 checks passed
@dagguh dagguh deleted the mark-3.1.6 branch June 12, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants