Stop testing Jiras which require Oracle JDK 1.8 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`OracleJDK` is flaky as hell. We just cannot make the tests pass, so we can't even release 3.2.0 with it. JSW supports alternative JDKs since 8.0.0.. No, [7.6] does not support it, see the [explanation]. JSM supports it since 3.16.0. [7.6]: https://confluence.atlassian.com/adminjiraserver076/supported-platforms-945110772.html [explanation]
dagguh
commented
Jun 19, 2024
| ), | ||
| DataCenterJmxProvisioningTest( |
There was a problem hiding this comment.
The shouldProvisionDataCenter used to spawn 2 threads, one for testing LB, one for testing JMX. I rolled it up into a single test.
|
This covers the mistake from #192 |
dagguh
changed the title
The routeIds size assertion failed on CI: ``` org.junit.ComparisonFailure: expected:<[2]> but was:<[1]> ``` Now we should get a bit better error message. We will see the singular route and its count. We might see that it's not the full 1000. Or it might just show a single route with 1000 count. We'll also get another CI trigger and see if it was a flake. It' s possible that the problem existed for a longer time, but `OracleJDK` flakiness was covering it up.
It fails on old code too: - checkout release-3.0.0 - rewrite locks - switch all Jira 7 to Jira 8 in the test So it looks like something changed beyond versions, ie. a newwer Apache 2 is being installed or sth like that. The problem requires investigation. However we need to release 3.2.0 to follow SemVer properly. Problems not introduced by 3.2.0 are ignored to release 3.2.0 I will re-enable the balance check broken balance test afterwards.
mgrzaslewicz
approved these changes
Jun 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OracleJDKis flaky as hell. We just cannot make the tests pass, so we can't even release 3.2.0 with it.JSW supports alternative JDKs since 8.0.0..
No, [7.6] does not support it, see the [explanation]. JSM supports it since 3.16.0.
[7.6]: https://confluence.atlassian.com/adminjiraserver076/supported-platforms-945110772.html [explanation]