Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version incrementer #194

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Fix version incrementer #194

merged 2 commits into from
Jun 24, 2024

Conversation

dagguh
Copy link
Contributor

@dagguh dagguh commented Jun 24, 2024

Confirmed locally:

./gradlew release -Prelease.versionIncrementer=incrementMinor -Prelease.dryRun

> Task :verifyRelease
DRY-RUN: uncommitted changes: false
Looking for uncommitted changes..
DRY-RUN: ahead of remote: true
Checking if branch is ahead of remote.. FAILED
Checking for snapshot versions..

> Task :release
Creating tag: release-3.2.0
DRY-RUN: creating tag with name: release-3.2.0
Pushing all to remote: origin
DRY-RUN: pushing to remote: origin

dagguh added 2 commits June 24, 2024 13:17
Confirmed locally:
```
./gradlew release -Prelease.versionIncrementer=incrementMinor -Prelease.dryRun

> Task :verifyRelease
DRY-RUN: uncommitted changes: false
Looking for uncommitted changes..
DRY-RUN: ahead of remote: true
Checking if branch is ahead of remote.. FAILED
Checking for snapshot versions..

> Task :release
Creating tag: release-3.2.0
DRY-RUN: creating tag with name: release-3.2.0
Pushing all to remote: origin
DRY-RUN: pushing to remote: origin
```
How many times can I fail releasing 3.2.0? :D
@dagguh dagguh requested a review from a team as a code owner June 24, 2024 11:19
@dagguh dagguh enabled auto-merge (rebase) June 24, 2024 11:28
@dagguh dagguh merged commit aa2a08b into master Jun 24, 2024
2 checks passed
@dagguh dagguh deleted the fix-version-incrementer branch June 24, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants