DCPERF-747 Update the aws-resources dependency #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the dependency to allow overriding the resource_owner label in Investment
|
No need to release a dependency bump. The consumers of aws-infra can bump aws-resources on their own if they need the new API. They don't have to rely on transitive deps. |
|
Actually what I'm trying to do is to fix the binary incompatibility that I encountered when bumping the library in the consumer. |
|
Yeah, that's an unfortunate trap of Kotlin data classes. We started avoiding them in API. BTW possibly Java record classes would be a better fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the dependency to allow overriding the resource_owner label in Investment