JPERF-838: Add Splunkforwarder.jsonifyLog4j method for Log4j1 and Log4j2 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagguh
suggested changes
Oct 18, 2022
src/test/kotlin/com/atlassian/performance/tools/infrastructure/api/splunk/Log4jJsonifierTest.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/atlassian/performance/tools/infrastructure/api/splunk/Log4jJsonifier.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/atlassian/performance/tools/infrastructure/api/splunk/SplunkForwarder.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/com/atlassian/performance/tools/infrastructure/api/splunk/Log4jJsonifierTest.kt
Outdated
Show resolved
Hide resolved
filip-nowak-atl
force-pushed
the
issue/JPERF-838-add-log4j2-jira-config-jsonification
branch
from
aa0b017 to
a4477a8
Compare
dagguh
suggested changes
Oct 18, 2022
src/main/kotlin/com/atlassian/performance/tools/infrastructure/api/splunk/SplunkForwarder.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/atlassian/performance/tools/infrastructure/api/splunk/SplunkForwarder.kt
Outdated
Show resolved
Hide resolved
dagguh
previously approved these changes
Oct 19, 2022
src/main/kotlin/com/atlassian/performance/tools/infrastructure/api/jira/JiraNodeConfig.kt
Outdated
Show resolved
Hide resolved
| private val log4jConfigFileName = log4j2ConfigFileName | ||
|
|
||
| override fun jsonifyLog4j(sshConnection: SshConnection, log4jPropertiesPath: String) { | ||
| val log4j2ConfigPath = Paths.get(log4jPropertiesPath).resolveSibling(log4jConfigFileName).toString() |
filip-nowak-atl
force-pushed
the
issue/JPERF-838-add-log4j2-jira-config-jsonification
branch
from
dc0d4e5 to
18281ea
Compare
dagguh
previously approved these changes
Oct 19, 2022
src/main/kotlin/com/atlassian/performance/tools/infrastructure/api/Sed.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/atlassian/performance/tools/infrastructure/splunk/Log4jJsonifier.kt
Outdated
Show resolved
Hide resolved
filip-nowak-atl
force-pushed
the
issue/JPERF-838-add-log4j2-jira-config-jsonification
branch
from
18281ea to
4a22d7a
Compare
…dle log4j2 config files.
filip-nowak-atl
force-pushed
the
issue/JPERF-838-add-log4j2-jira-config-jsonification
branch
from
4a22d7a to
6daf5cf
Compare
dagguh
approved these changes
Oct 19, 2022
| import com.atlassian.performance.tools.ssh.api.SshConnection | ||
| import java.nio.file.Paths | ||
|
|
||
| class Log4j2SplunkForwarder(log4j2ConfigFileName: String, splunkForwarder: SplunkForwarder) : |
There was a problem hiding this comment.
This is new API and it's a good thing. It's a way to offer the fix to anyone, who's not going through the JiraNodeConfig.Builder. @atlassian/jpt, this will be a minor release.
|
FYI I wasn't convinced that this change wasn't breaking module's API so I checked with japicmp and the report confirmed that minor release if correct ✅ Can't attach the report, because github rejects HTML attachements + chrome for some reason crashes when taking full page screenshot ¯\_(ツ)_/¯ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jsonify both log4j 1 and log4j 2 config files