Preventing unnecessary AnimateInOut re-renderings #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hooray! All contributors have signed the CLA. |
nfantone
changed the title
nfantone
force-pushed
the
fix/droppable-rerenders
branch
from
d4243b2 to
e1d3559
Compare
nfantone
force-pushed
the
fix/droppable-rerenders
branch
from
e1d3559 to
9073656
Compare
|
🦗. |
|
🦗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While following the video tutorial on perf optimizations, I encountered a few preventable tree re-renderers coming from within
react-beautiful-dnditself, thanks towdyr.Draggableon the screen re-sets its state to the same default values ingetDerivedStateFromProps.Droppableplaceholder forces anAnimateInOutre-render by creating a newchildrenfunction each time.This PR fixes both.