Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/update dependencies #9

Merged
merged 11 commits into from
Oct 24, 2024
Merged

Refactor/update dependencies #9

merged 11 commits into from
Oct 24, 2024

Conversation

OsirisAnubiz
Copy link
Member

No description provided.

@OsirisAnubiz OsirisAnubiz linked an issue Oct 21, 2024 that may be closed by this pull request
Обновление зависимостей @atls/grpc-error-status #6
Closed
@OsirisAnubiz OsirisAnubiz requested a review from Nelfimov October 21, 2024 14:54
@OsirisAnubiz
Copy link
Member Author

@Nelfimov готово. Единственное что не работает yarn proto:generate и yarn proto:lint. Не знаю должно ли так быть. build и prepack работает

Nelfimov
Nelfimov requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@Nelfimov Nelfimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. перевести на есм
  2. бампнуть вручную на мажорную версию

@OsirisAnubiz
Copy link
Member Author

@Nelfimov библиотека google-protobuf не поддерживает esm. На их github репозитории написанно следующее:

The library is currently compatible with:
1. CommonJS-style imports (eg. var protos = require('my-protos');)
2. Closure-style imports (eg. goog.require('my.package.MyProto');)
Support for ES6-style imports is not implemented yet. Browsers can be supported by using Browserify, webpack, Closure Compiler, etc. to resolve imports at compile time

Мне использовать createRequire или какой-то из предложенных ими вариантов?

@OsirisAnubiz
Copy link
Member Author

сделал через `"moduleResolution": "Node"

@Nelfimov
Copy link
Member

createRequire и NodeNext

@OsirisAnubiz OsirisAnubiz requested a review from Nelfimov October 23, 2024 13:51
Nelfimov
Nelfimov requested changes Oct 24, 2024
View reviewed changes
.yarnrc.yml Outdated
dependencies:
long: "*"
long: '*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужно ли нам это после бампа версий?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нет, удалил

packages/grpc-error-status/package.json Outdated
"build": "yarn library build",
"prepack": "yarn run build",
"postpack": "rm -rf dist"
"postpack": "rm -rf dist",
"proto:generate": "PATH=$PATH:$(yarn bin protoc-gen-ts) buf generate",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

скрипты работают? Помню у них cli менялось

@OsirisAnubiz OsirisAnubiz requested a review from Nelfimov October 24, 2024 09:26
@Nelfimov Nelfimov merged commit 3fb32bb into master Oct 24, 2024
6 checks passed
@Nelfimov Nelfimov deleted the refactor/update-dependencies branch October 24, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nelfimov Nelfimov Awaiting requested review from Nelfimov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Обновление зависимостей @atls/grpc-error-status
2 participants
@OsirisAnubiz @Nelfimov