Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/invite-member-modal #40

Merged
merged 27 commits into from
Jul 25, 2024
Merged

feat/invite-member-modal #40

merged 27 commits into from
Jul 25, 2024

Conversation

kirill-ivanovvv
Copy link
Member

@kirill-ivanovvv kirill-ivanovvv commented Jul 24, 2024 •
edited
Loading

closes #39

@kirill-ivanovvv kirill-ivanovvv self-assigned this Jul 24, 2024
@kirill-ivanovvv
yarn
a8dbe96
@kirill-ivanovvv
refactor: remane add-member-modal to invite-member-modal
a1c0ae7
@kirill-ivanovvv
refactor(stores/toast): remove unused deps
ab84e0b
@kirill-ivanovvv
feat(globals/mail): init package
d1f9126
@kirill-ivanovvv
refactor(invite-member-modal): state fixes; change button to invite-b…
539a7e8 
…utton; rename component to invite-modal... (from add-modal...); and some else...
@kirill-ivanovvv
refactor(invite-button): separate constants
3a90390
@kirill-ivanovvv
feat(entrypoint): add toast
a1577bc
@kirill-ivanovvv
feat(api/send-invite): init api-endpoint
786778a
@kirill-ivanovvv
feat(entrypoint): provide an send-invite endpoint
879e85a
@kirill-ivanovvv
feat(invite-member-modal): add an fetch interface to send-invite endp…
ff8169d 
…oint
@kirill-ivanovvv
feat(globals/mail): init package; add send-invite templates (message …
ae80f1c 
…and layout)
@kirill-ivanovvv
feat(api/send-invite-endpoint): response error
144582d
@kirill-ivanovvv
feat(env): add data for smtp
5240d23
@kirill-ivanovvv
feat(invite-member-modal):throw erro if status is not 200
6b233bc
@kirill-ivanovvv
refactor(invite-member-modal): separate switch datas to constants
cb258df
@kirill-ivanovvv
feat(enviroment): add smtpt envs to check env func
497178d
@kirill-ivanovvv
refactor(globals/mail): provide smtp data from env; clean code
cbfd5d7
@kirill-ivanovvv
refactor(invite-button): interfaces; sintax
109c661
@kirill-ivanovvv
refator(invite-member-modal): interfaces; separate gh-auth-hook
9ce019b
@kirill-ivanovvv
refactor(users-title): prettier fixes
8888422
@kirill-ivanovvv
feat(rest-queries): add invite member to org by gh api QUERY
9081782
@kirill-ivanovvv
refactor(helpers): export document type
da01295
@kirill-ivanovvv
refactor(globals/mail): rewrite tempate - make it string; desigh in p…
126ed2f 
…rocess
@kirill-ivanovvv
yarn
4f6b9a0
@kirill-ivanovvv
Copy link
Member Author

@Nelfimov можем провести ревью без дизайна письма, он в процессе? на данный момент сверстал строку, возвращаю её как html

почту для тестов использую эту - https://ethereal.email
login - [email protected]
pass - d4P4DrQy9QtWuvCe8F

он не рассылает письма, но показывает в отправленных. делал по документации nodeailer, там и нашел этот сервис

кинул приглашение в тестовую организацию на гитхабе, от её лица отправляются инвайты на почту
активные инвайты будут отображаться вот тут - https://github.com/orgs/effectivnayarabota1-test-organization/people/pending_invitations

ревью запросил

@kirill-ivanovvv kirill-ivanovvv marked this pull request as ready for review July 25, 2024 09:26
@kirill-ivanovvv kirill-ivanovvv requested a review from Nelfimov July 25, 2024 09:27
@Nelfimov
Copy link
Member

@Nelfimov можем провести ревью без дизайна письма, он в процессе? на данный момент сверстал строку, возвращаю её как html

почту для тестов использую эту - https://ethereal.email login - [email protected] pass - d4P4DrQy9QtWuvCe8F

он не рассылает письма, но показывает в отправленных. делал по документации nodeailer, там и нашел этот сервис

Используй любую свою почту для тестов. Хоть яндекс, хоть gmail. На личной почте яндекса я успешно тестировал свои сервисы.

Nelfimov
Nelfimov requested changes Jul 25, 2024
View reviewed changes
globals/data/src/rest-queries/invite-member-to-organization-email.query.ts Show resolved Hide resolved
globals/environment/src/check-envs.constants.ts Outdated Show resolved Hide resolved
app/api/send-invite-mail/src/send-invite-mail.api.ts Outdated Show resolved Hide resolved
app/entrypoints/renderer/package.json Outdated Show resolved Hide resolved
app/entrypoints/renderer/package.json Outdated Show resolved Hide resolved
@kirill-ivanovvv kirill-ivanovvv requested a review from Nelfimov July 25, 2024 12:27
@Nelfimov Nelfimov merged commit e0899dd into master Jul 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nelfimov Nelfimov Nelfimov approved these changes

Assignees

@kirill-ivanovvv kirill-ivanovvv

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

модальное окно - приглашение участника команды
2 participants
@kirill-ivanovvv @Nelfimov