Feat/users page #42

kirill-ivanovvv · 2024-07-26T09:55:40Z

closes #32

…; remove interfaces; create query constants(limits)

…dont change it

…nizations data with members data

… for re-renders after deletion)

…eded

…ields in query

kirill-ivanovvv · 2024-07-31T16:46:26Z

@Nelfimov

сделал те проверки, что могу без сторонних сервисов, только гитхаб - 2fa и основная организация
прочертил маршруты для входящих данных
добавил хук удаления из организации в карточке юсера
перечертил пару компонентов, пару фрагментов
выправил интерфейсы

основное мясо вот в этом хуке: https://github.com/atls/team-management/blob/feat/users-page/app/fragments/app-member-cards-grid/src/hooks/get-members-data.hook.ts
большая константа онбординга вот тут: https://github.com/atls/team-management/blob/feat/users-page/app/fragments/app-member-cards-grid/src/member-cards-grid.constants.ts
- возможно её нужно вынести?

с объектами получилось запутанно у меня, но работает.
я хотел избежать дополнительных запросов, потомучто запрашвать данные организации для каждого пользователя может быть дорого в плане лимитов.
поэтому делаю через один запрос.
мы запрашиваем организации, в них юсеры, но рендинить нам надо юсеров, а в них организации. вот здесь это происходит
делаю промежуточный объект со связями юсер -> организации, потом собираю массив с мемберами и связываю мембера с организацией из первого объкта. + фильтр на уникальность. + добавляю параметр условия онбординга onbordingData
для меня это остается немного запутанным моментом, поэтому расписал на всякий случай.

запрашиваю ревью

Nelfimov

Встреченные ошибки:

Не смог оставить замечание - get-onboarding-condition-icon.hook.ts используй свитч

globals/mail/src/send-mail.mail.ts

app/fragments/app-invite-member-modal/src/hooks/send-invite-email.hook.ts

app/fragments/app-member-card/src/helpers/index.ts

app/fragments/app-member-card/src/member-card.constants.tsx

app/fragments/app-member-card/src/image-group/image-group.component.tsx

app/fragments/app-member-cards-grid/src/member-cards-grid.component.tsx

app/fragments/app-member-cards-grid/src/member-cards-grid.constants.ts

app/fragments/app-member-cards-grid/src/member-cards-grid.hook.ts

...p-organizations-modal/src/organization-element/hooks/remove-member-from-organization.hook.ts

…aces

…tefaces

globals/constants/src/init-onbording-data.constant.ts

globals/third-party/package.json

app/fragments/app-member-card/src/member-card.constants.tsx

kirill-ivanovvv added 2 commits July 26, 2024 12:54

fix(base-layout): add horizontal paddings

41aa006

feat(layout): add breakpoints; add styles to grids with that blabla

9f6c9b8

kirill-ivanovvv added the feature label Jul 26, 2024

kirill-ivanovvv self-assigned this Jul 26, 2024

kirill-ivanovvv added 26 commits July 26, 2024 14:22

refactor: organizations and members namings

bd5fd31

draft(member-card): layout in process

27d9057

feat(member-cards-grid): get member; filter unique

beec3ab

refactor(org-card): package rename

8290a96

refactor(org-cards-grid): raname component; rename functions components

6197475

refactor(members-page): move all login and data functions to fragment…

4252c05

…; remove interfaces; create query constants(limits)

feat(queries): add getViewerAllOrganizationsAllMembers query

1048116

feat(cookie-helper): throw error if token not exist

4b5928f

refactor(checkbox): remove logic from component

3302d78

feat(ui/progress): create component

c2f1096

feat(theme/spaces): add params

a1b9c2e

yarn

248c5b8

refactor: delete unused

6bcedf5

feat(icons): add timer icon color prop

af889b8

refactor: delete unused tags

d685a44

refactor: delete unused

a5634a4

draft: member card layout WIP

6be3c54

yarn

c1bcf30

fix(checkbox): change checked prop to defaultChecked, because client …

5bb4f21

…dont change it

feat(member-cards-hook): write organizations data to state; link orga…

c33b74a

…nizations data with members data

refactor(locales): added entries

871c3a5

refactor(base-layout): change paddings

8490258

refactor(member-card): separate to sub-components mostly

c17023f

feat(member-cards-grid): provide organizaitons data to childst (needs…

16e60db

… for re-renders after deletion)

refactor(organizatoins-modal): rewrite component fully; rest hooks ne…

e78d594

…eded

feat(get-viewer-all-organizations-all-members): add login and email f…

9dd1084

…ields in query

refactor: interfaces mostly

79f649b

kirill-ivanovvv marked this pull request as ready for review July 31, 2024 16:46

kirill-ivanovvv requested a review from Nelfimov July 31, 2024 16:46

Nelfimov requested changes Aug 1, 2024

View reviewed changes

kirill-ivanovvv added 16 commits August 1, 2024 13:26

refactor: change octokit interfaces

4ed8699

refactor(member-cards): remove unused; separate consts

5e43ffe

refactor(octokit-graphql-client): change function-interface

4fbc62c

refactor(octokit-rest): interfaces

42f1c76

refactor(octokit-graphql): interfaces

a9b99b8

refactor(gh-api): move get token func to third party

54bc486

refactor: ts

a4a2603

fix: redirect if token not exist

0165c21

feat(invite-member-modal): provide a toast to erro notify

331ca6a

refactor(member-card): rename helpers to getters; interfaces

d1d67a6

refactor(member-cards-grid): refactoring; devided into pieces; interf…

a367398

…aces

refactor(onbording-condition-element): change forOfLoop to switch; in…

0c3ca71

…tefaces

fix(organiations-modal); change getqueryinterfacename

a2e4730

feat(globals/constants): move condition constants from some component

8a8d699

feat(globals/data): export onbording condition data type

9d49262

yarn

ff7eb93

kirill-ivanovvv requested a review from Nelfimov August 1, 2024 14:45

Nelfimov requested changes Aug 2, 2024

View reviewed changes

globals/constants/src/init-onbording-data.constant.ts Outdated Show resolved Hide resolved

globals/third-party/package.json Outdated Show resolved Hide resolved

app/fragments/app-member-card/src/member-card.constants.tsx Outdated Show resolved Hide resolved

kirill-ivanovvv added 4 commits August 3, 2024 18:17

refactor(globals): rename third-party to github-hooks

5acf777

refactor(member-card): interface fixes

58c1c4a

refactor(globals/constants): change ru comments to eng

36855a7

yarn

7f1be29

kirill-ivanovvv requested a review from Nelfimov August 3, 2024 15:19

Nelfimov approved these changes Aug 5, 2024

View reviewed changes

Nelfimov merged commit 43a3d21 into master Aug 5, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/users page #42

Feat/users page #42

kirill-ivanovvv commented Jul 26, 2024 •

edited

Loading

kirill-ivanovvv commented Jul 31, 2024 •

edited

Loading

Nelfimov left a comment

Feat/users page #42

Feat/users page #42

Conversation

kirill-ivanovvv commented Jul 26, 2024 • edited Loading

kirill-ivanovvv commented Jul 31, 2024 • edited Loading

Nelfimov left a comment

Choose a reason for hiding this comment

kirill-ivanovvv commented Jul 26, 2024 •

edited

Loading

kirill-ivanovvv commented Jul 31, 2024 •

edited

Loading