Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes textEdit completions #101

Closed
wants to merge 3 commits into from
Closed

Fixes textEdit completions #101

wants to merge 3 commits into from

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Oct 30, 2020

@UziTech UziTech marked this pull request as draft October 30, 2020 05:52
@UziTech
Copy link
Member Author

UziTech commented Oct 30, 2020

This should have tests to make sure it does what it is supposed to before it gets merged.

@UziTech UziTech added the needs tests PR needs tests before merging label Dec 12, 2020
@aminya aminya marked this pull request as ready for review January 6, 2021 06:06
aminya
aminya reviewed Jan 6, 2021
View reviewed changes
Copy link
Member

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to get this in too

@UziTech
Copy link
Member Author

UziTech commented Jan 6, 2021

I'm not sure this is needed. it seems like this fixes the same thing as #100

@UziTech
Copy link
Member Author

UziTech commented Jan 6, 2021

Ya I'm pretty sure this is already fixed unless @isundaylee can shed some light on what this fixes.

@UziTech UziTech closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminya aminya aminya left review comments

Assignees
No one assigned
Labels
needs tests PR needs tests before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix text completions
2 participants
@UziTech @aminya