Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow disabling shutdownGracefully #161

Merged
merged 1 commit into from
Jun 13, 2021
Merged

Conversation

aminya
Copy link
Member

@aminya aminya commented Jun 12, 2021

Requires #160 (only the last commit is related to this PR). It was possible to make this based on master, but then we had to fix some conflicts later

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase after #160 is merged and add tests

Setting it to false allows quick killing of the servers instead of
waiting

Co-Authored-By: Alex Butler <[email protected]>
@aminya aminya force-pushed the shutdownGracefully-config branch from 6587129 to 14bec25 Compare June 13, 2021 15:46
@aminya
Copy link
Member Author

aminya commented Jun 13, 2021

I opened an issue for the additional test #164. Feel free to take it. I will merge this PR as the change itself is trivial.

@aminya aminya merged commit 1c2b2cd into master Jun 13, 2021
@aminya aminya deleted the shutdownGracefully-config branch June 13, 2021 15:53
@github-actions
Copy link

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants