This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
When publishing an atom package through the apm, if the repository is set on the default "main" branch (new git standard), you would get an error. This is because the publish script is looking for a "master" branch (old standard):
The new git convention is that the main branch should be named "main". Instead of checking for the master branch, I first check if there is a "main" branch, then I check if there is a "master" branch.
If I got something wrong, please tell me: this is my first ever pull request. My request might be bad, and I am aware that you normally don't tell people when their requests were rejected (it is written in this text file, in the comments), but please tell me why this might be the case, so I know how to do them in the future
Alternate Designs
You could also only check for the main branch, not checking for the master branch afterwards.
Benefits
You will not get the error saying the git repo is not valid (not an atom package, not sufficient permission or it doesn't exist)
Possible Drawbacks
I cannot think of a possible drawback.
Verification Process
Applicable Issues