Merge pull request #251 from Aerijo/master

Support null completions
atom · Mar 4, 2019 · 319b95a · 319b95a
2 parents 5fc887f + c04a2e8
commit 319b95a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/adapters/autocomplete-adapter.ts b/lib/adapters/autocomplete-adapter.ts
@@ -278,11 +278,11 @@ export default class AutocompleteAdapter {
   //
   // Returns a {Map} of AutoComplete+ suggestions ordered by the CompletionItems sortText.
   public completionItemsToSuggestions(
-    completionItems: CompletionItem[] | CompletionList,
+    completionItems: CompletionItem[] | CompletionList | null,
     request: ac.SuggestionsRequestedEvent,
     onDidConvertCompletionItem?: CompletionItemAdjuster,
   ): Map<ac.AnySuggestion, PossiblyResolvedCompletionItem> {
-    return new Map((Array.isArray(completionItems) ? completionItems : completionItems.items || [])
+    return new Map((Array.isArray(completionItems) ? completionItems : (completionItems && completionItems.items || []))
       .sort((a, b) => (a.sortText || a.label).localeCompare(b.sortText || b.label))
       .map<[ac.AnySuggestion, PossiblyResolvedCompletionItem]>(
         (s) => [

diff --git a/lib/languageclient.ts b/lib/languageclient.ts
@@ -241,7 +241,7 @@ export class LanguageClientConnection extends EventEmitter {
   // Returns a {Promise} containing either a {CompletionList} or an {Array} of {CompletionItem}s.
   public completion(
     params: lsp.TextDocumentPositionParams | CompletionParams,
-    cancellationToken?: jsonrpc.CancellationToken): Promise<lsp.CompletionItem[] | lsp.CompletionList> {
+    cancellationToken?: jsonrpc.CancellationToken): Promise<lsp.CompletionItem[] | lsp.CompletionList | null> {
     // Cancel prior request if necessary
     return this._sendRequest('textDocument/completion', params, cancellationToken);
   }