Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fixes textEdit completions #254

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes textEdit completions #254

wants to merge 2 commits into from

Commits on Feb 23, 2019

  1. Fixes textEdit completions 

    Currently the original replacement prefix sent by the LSP server in the
`textEdit` field is overwritten in getSuggestions(). This, for example,
causes the following case:

    foo->

to autocomplete to

    foo->->bar()

instead of the expected

    foo->bar()

This commit fixes the issue by saving the original replacement prefix
(`->` in the example above), and modifying `getSuggestions()` to append
to instead of overwrite this original replacement prefix.
    @isundaylee
    isundaylee committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    6d1e984 View commit details
    Browse the repository at this point in the history

  2. Removes unnecessary triggerPrefix argument to getOrBuildSuggestions

    @isundaylee
    isundaylee committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    86a9ac2 View commit details
    Browse the repository at this point in the history