This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Use scandal to build the project file list #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atom core has scandal, which is _all about_ building a list of files in a fairly efficient manner, and thinking about VCS issues and symbolic links and whatnot. Instead of reimplementing pieces of that, just use it. This has the nice side-effect of fixing issue atom#111, because scandal is better at deciding which files should be ignored.
It's arguable which way this should go; tree-view and find-in-project both treat a parent gitignore as authorative, but fuzzy-finder current tests require that it be ignored. As such, I've implemented this in a way that'd make it easy to switch the behavior around.
This was referenced Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atom core has scandal, which is all about building a list of files
in a fairly efficient manner, and thinking about VCS issues and
symbolic links and whatnot. Instead of reimplementing pieces of that,
just use it.
This has the nice side-effect of fixing issue #111, because scandal is
better at deciding which files should be ignored.