#827 Fix allows-only always set in ontology editor

atomicdata-dev · Jan 30, 2024 · b47684f · b47684f
1 parent 7907d71
commit b47684f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/browser/data-browser/src/views/OntologyPage/Property/EnumFormPart.tsx b/browser/data-browser/src/views/OntologyPage/Property/EnumFormPart.tsx
@@ -73,9 +73,12 @@ const TagPanel: FC<TagPanelProps> = ({ resource, ontology }) => {
     // We filter out anything that is not a tag.
     filterAllowsOnly(resource, dataBrowser.classes.tag, store).then(
       filteredTags => {
-        setTags(filteredTags);
+        setTags(filteredTags ?? []);
 
-        if (filteredTags.length === allowsOnly.length) {
+        if (
+          filteredTags === undefined ||
+          filteredTags.length === allowsOnly.length
+        ) {
           return;
         }
 

diff --git a/browser/data-browser/src/views/OntologyPage/Property/filterAllowsOnly.ts b/browser/data-browser/src/views/OntologyPage/Property/filterAllowsOnly.ts
@@ -4,8 +4,13 @@ export async function filterAllowsOnly(
   resource: Resource<Core.Property>,
   isA: string,
   store: Store,
-): Promise<string[]> {
-  const allowsOnly = resource.props.allowsOnly ?? [];
+): Promise<string[] | undefined> {
+  const allowsOnly = resource.props.allowsOnly;
+
+  if (allowsOnly === undefined) {
+    return;
+  }
+
   const filteredTags: string[] = [];
 
   for (const line of allowsOnly) {