Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#966 nextjs example template #1009

Draft
wants to merge 30 commits into
base: develop
Choose a base branch
from
Draft

#966 nextjs example template #1009

wants to merge 30 commits into from

Conversation

joepio
Copy link
Member

@joepio joepio commented Nov 4, 2024 •
edited
Loading

Related Issues

Todo

  • Feature parity with Sveltekit template
    • Render a dynamic page
    • Menu items
    • Search bar
    • Search results
  • Update Generator to support template
  • Readme for local dev
  • Update docs
  • Give feedback in this issue, e.g. about reusable component needs
  • Netlify deploy in readme
  • Try a netlify deploy, see if it all works (Statically / SSR)

Checklist

  • Add changelog entry linking to issue, describe API changes
  • Add or update tests if needed
  • Update docs if needed

@joepio joepio requested a review from Polleps November 4, 2024 10:31
joepio
joepio commented Nov 4, 2024
View reviewed changes
browser/create-template/templates/nextjs-site/src/views/Block/ImageGalleryBlock.tsx
<div className={styles.wrapper}>
{resource.props.images?.map((image: string, index: number) => (
<div key={index} className={styles.image}>
<Image subject={image} alt='' />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use file description / name

joepio
joepio commented Nov 4, 2024
View reviewed changes
browser/create-template/templates/nextjs-site/src/views/FullPage/BlogpostFullPage.tsx Outdated
return (
<Container>
<div className={styles.blogWrapper}>
<Image subject={resource.props.coverImage} alt='' />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image comp should deal with that

@RoelLeijser RoelLeijser force-pushed the #966-nextjs-example-template branch from a94e443 to cc75ad6 Compare November 6, 2024 12:20
Polleps
Polleps requested changes Nov 11, 2024
View reviewed changes
browser/create-template/templates/nextjs-site/next.config.mjs Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/app/[...slug]/page.tsx Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/app/globals.css Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/app/layout.tsx Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/components/Layout/HStack.module.css Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/views/ListItem/BlogListItem.tsx Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/views/MenuItem/MenuItem.tsx Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/views/MenuItem/MenuItem.tsx Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/views/MenuItem/MenuItem.tsx Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/views/MenuItem/MenuItem.tsx Outdated Show resolved Hide resolved
@RoelLeijser RoelLeijser force-pushed the #966-nextjs-example-template branch from 82b887c to 6d00312 Compare November 14, 2024 15:44
joepio
joepio commented Nov 25, 2024
View reviewed changes
browser/create-template/templates/nextjs-site/README/DEPLOYING.md Outdated
@@ -0,0 +1,15 @@
# Deploying
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to README.md

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, discuss SSR / SSG limitations

@RoelLeijser RoelLeijser force-pushed the #966-nextjs-example-template branch from 239bfaa to bb64c70 Compare December 9, 2024 15:58
@RoelLeijser
Add blog page
e746d8b
@RoelLeijser
Add CurrentSubjectContext with errors
588141c
@RoelLeijser
Start migrating to server components (breaking)
f05e805
@RoelLeijser
Upgrade next to v15
0f6de05
@RoelLeijser
Update template to server components
22eab73
@RoelLeijser
Migrate to ESLint v9
4c0da26
@RoelLeijser
Modified the Search functionality to server components with streaming
c99c472
@RoelLeijser
Refactor for client side
25f7aaa
@RoelLeijser
Implement feedback
064769a
@RoelLeijser
Update README.md
1df794a
@RoelLeijser
Move store
c07c027
@RoelLeijser
Enhance Next.js template
fcda0f5
@RoelLeijser
Implement feedback and fixes
09c1e21
@RoelLeijser
Add dynamic file extension handling in ontology index generation when…
53e7c6e 
… using bundler
@RoelLeijser
Add cli support for Next.js template
bd95072
@RoelLeijser
Small fixes
b8f01ed
@RoelLeijser
Refactor CSS styles and update navbar
9124705
@RoelLeijser
Refactor MenuItem components
0815c3d
@RoelLeijser
Add deployment instructions for Netlify in README
9bad3ca
@RoelLeijser
Refactor layout and context management
8595ab2
@RoelLeijser
Refactor MenuItem components and update dependencies
8fe34f8
@RoelLeijser
Add deployment instructions for Netlify and Vercel to README, remove …
813e4db 
…old DEPLOYING.md
@RoelLeijser
Add nextjs-site template to documentation
53eed8f
@RoelLeijser RoelLeijser force-pushed the #966-nextjs-example-template branch from 1a6ff6f to 53eed8f Compare December 10, 2024 13:59
@joepio
Copy link
Member Author

joepio commented Dec 16, 2024

Netlify and Vercel now working, Netlify had some issues (CSS not working)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoelLeijser RoelLeijser RoelLeijser left review comments

@Polleps Polleps Polleps requested changes

Assignees

@RoelLeijser RoelLeijser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NextJS example template
3 participants
@joepio @Polleps @RoelLeijser