Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Vite and TS #710

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Upgrade Vite and TS #710

merged 3 commits into from
Nov 27, 2023

Conversation

Polleps
Copy link
Member

@Polleps Polleps commented Nov 27, 2023

PR Checklist:

  • Link to related issues: #number
  • Add changelog entry linking to issue, describe API changes
  • Add tests (optional)
  • (If new feature) add to description / readme

@Polleps Polleps marked this pull request as ready for review November 27, 2023 13:58
@joepio joepio merged commit 46f8a44 into develop Nov 27, 2023
2 of 3 checks passed
albertchae added a commit to ngi-nix/atomic-server that referenced this pull request Mar 6, 2024
…uses one typescript version (5.3.2)

We came across this while working on ngi-nix/ngipkgs#164.
While not strictly necessary for that task, it seemed like it was unintentional
that the project was depending on different versions of typescript (PR with original
upgrade is atomicdata-dev#710), so
I removed typescript in the various subdirectories so they all depend
on the same version as root.

- Edit tsconfig.build.json to fix the following error
  `TS5110: Option 'module' must be set to 'NodeNext' when option 'moduleResolution' is set to 'NodeNext'.`

- All the removed packages from pnpm-lock.yaml are duplicate entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants