Stuck pending swaps #363
Merged
Stuck pending swaps #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/renderer/swap-db.js
Outdated
|
|
||
| // We need to regularly check if pending swaps have timed out. | ||
| // https://github.com/jl777/SuperNET/issues/775 | ||
| const ONE_MINUTE = 60000; |
There was a problem hiding this comment.
60000 => 1000 * 60 is more readable. To ensure the value is actually correct.
|
Yay! My trades view is finally cleaned up :D |
|
🎉 This is also a prerequisite for a potential fix for the stuck swaps halfway through I want to try out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #279
There is a bug in
marketmakerwhen a swap get's some communication from a peer (like areservedmessage) but never matches. In this scenario an error message is never sent so the swap is displayed as pending in the GUI forever.This is a bit of a hack but it resolves the issue and should be fine until
marketmakerv2.It just displays swaps that are pending for more the 5 minutes as unmatched and emits a fake DB change event every minute to force a recalculation.
marketmakerissue: jl777/SuperNET#775