Fix nif declarations in esp_adc module

[pguyot]

Use proper erlang:nif_error(undefined) so that dialyzer doesn't consider the functions never return.

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

[bettio]

If you don't mind (and it doesn't take too much time) it would be a good fix for release-0.6.

[UncleGrumpy]

Thanks for this @pguyot, I didn’t even think to test this with dialyzer because I have had some difficulties using it on AtomVM apps. I seem to get warnings that lead me to believe it is checking against OTP libraries and not AtomVM stdlib.

[pguyot]

Thanks for this @pguyot, I didn’t even think to test this with dialyzer because I have had some difficulties using it on AtomVM apps. I seem to get warnings that lead me to believe it is checking against OTP libraries and not AtomVM stdlib.

Now that AtomVM installs .erl modules, we should create rebar3 atomvm dialyzer that will do the right thing: build a plt from AtomVM libs and run dialyzer on sources with this plt.

[UncleGrumpy]

Now that AtomVM installs .erl modules, we should create rebar3 atomvm dialyzer that will do the right thing: build a plt from AtomVM libs and run dialyzer on sources with this plt.

This makes perfect sense, it felt like something was missing ;-)