Add inet:getaddr/2
#1396
Add inet:getaddr/2
#1396
Conversation
There was a problem hiding this comment.
Looks good, I would use domain and IP addresses that are safe for examples and tests such as example.com and its IP address.
As a side note it would be better to target main and keep this branch focused to disterl and its dependencies (also for review reasons), but I'm not that strong opinionated about this.
tests/libs/estdlib/test_inet.erl
Outdated
| {ok, {127, 0, 0, 1}} = inet:getaddr(localhost, inet), | ||
| {ok, {127, 0, 0, 1}} = inet:getaddr("localhost", inet), | ||
| {ok, {_, _, _, _}} = inet:getaddr("www.atomvm.net", inet), | ||
| {ok, {173, 48, 222, 98}} = inet:getaddr("pool-173-48-222-98.bstnma.fios.verizon.net", inet), |
There was a problem hiding this comment.
as far as I know example.com is guaranteed to be static and assigned to 93.184.216.34.
There was a problem hiding this comment.
I’m not sure about this statement and it seems example.com resolves differently here and on CI.
pguyot
force-pushed
the
w50/add-inet-getaddr
branch
2 times, most recently
from
902a485 to
100faf4
Compare
This is a dependency of disterl. I wrote a dist layer implementation called |
pguyot
force-pushed
the
w50/add-inet-getaddr
branch
from
100faf4 to
0a4236f
Compare
Signed-off-by: Paul Guyot <[email protected]>
pguyot
force-pushed
the
w50/add-inet-getaddr
branch
from
0a4236f to
63e3961
Compare
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later