Reduce lock contention on GlobalContext.module_locks #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Cache last module in scheduler loop to reduce lookups of modules by index Also fix a bug in stacktraces where the lock was not held Also remove pointer to GlobalContext from modules This optimization, in addition to PRs atomvm#766, atomvm#770, atomvm#771 and atomvm#772, bring an additional gain of 2-3% on Sudoku benchmark Signed-off-by: Paul Guyot <[email protected]>
pguyot
force-pushed
the
w33/reduce-lock-contention-on-module-index
branch
from
9e0c8e3 to
003a549
Compare
This was referenced Aug 21, 2023
bettio
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache last module in scheduler loop to reduce lookups of modules by index
Also fix a bug in stacktraces where the lock was not held
Also remove pointer to GlobalContext from modules
This optimization, in addition to PRs #766, #770, #771 and #772, brings an additional gain of 2-3% on Sudoku benchmark
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later