chore: address review comments & cleanup work

atsign-foundation · Dec 19, 2024 · 56e318f · 56e318f
1 parent c91b161
commit 56e318f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/packages/atclient/include/atclient/monitor.h b/packages/atclient/include/atclient/monitor.h
@@ -10,11 +10,6 @@ extern "C" {
 #include <atchops/platform.h> // IWYU pragma: keep
 #include <stdbool.h>
 
-// HACK let's just get it working for now this is so wrong
-#ifndef MBEDTLS_ERR_SSL_TIMEOUT
-#define MBEDTLS_ERR_SSL_TIMEOUT -37
-#endif
-
 /**
  * @brief Represents a message received from the monitor connection, typically derived from the prefix of the response
  * (e.g. "data:ok"'s message type would be "data" = ATCLIENT_MONITOR_MESSAGE_TYPE_DATA_RESPONSE)

diff --git a/tests/functional_tests/tests/test_atclient_get_atkeys.c b/tests/functional_tests/tests/test_atclient_get_atkeys.c
@@ -144,7 +144,6 @@ exit: {
 
 static int test_4_atclient_get_atkeys_null_regex(atclient *ctx, const char *scan_regex, const bool showhidden) {
   int ret = 1;
-  return 0; // NOTE: disabled temporarily DONT LET THIS GET MERGED
 
   atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_DEBUG, "test_4_atclient_get_atkeys_null_regex\n");