fix: introduce init method and use for enroll namespace list

atsign-foundation · Dec 18, 2024 · acdc3ea · acdc3ea
1 parent e6fb8de
commit acdc3ea
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/packages/atauth/src/auth_cli.c b/packages/atauth/src/auth_cli.c
@@ -206,8 +206,7 @@ int main(int argc, char *argv[]) {
    */
   // 3.1 Initialize and populate enrollment params structs
   atcommons_enroll_namespace_list_t *ns_list = malloc(sizeof(atcommons_enroll_namespace_list_t));
-  if (ns_list == NULL) {
-    atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "Could not allocate memory for namespace list\n");
+  if((ret = atcommmons_init_enroll_namespace_list(ns_list)) != 0) {
     goto enc_pub_key_exit;
   }
 

diff --git a/packages/atcommons/include/atcommons/enroll_namespace.h b/packages/atcommons/include/atcommons/enroll_namespace.h
@@ -1,6 +1,7 @@
 #ifndef ATCOMMONS_ENROLL_NAMESPACE_H
 #define ATCOMMONS_ENROLL_NAMESPACE_H
 
+#include <atlogger/atlogger.h>
 #include <stddef.h>
 
 typedef struct {
@@ -13,6 +14,14 @@ typedef struct {
   atcommons_enroll_namespace_t *namespaces[];
 } atcommons_enroll_namespace_list_t;
 
+/**
+ * @brief intializes the provided atcommons_enroll_namespace_list_t struc
+ *
+ * @param ns_list pointer to the namespace list struct that needs to be initialized
+ * @return int 0 on success, non-zero int on failure
+ */
+int atcommmons_init_enroll_namespace_list(atcommons_enroll_namespace_list_t *ns_list);
+
 /**
  * @brief serializes enroll_namespace struct to JSON string
  *

diff --git a/packages/atcommons/src/enroll_namespace.c b/packages/atcommons/src/enroll_namespace.c
@@ -10,6 +10,17 @@
 
 #define TAG "enroll_namespace"
 
+int atcommmons_init_enroll_namespace_list(atcommons_enroll_namespace_list_t *ns_list) {
+  if(ns_list == NULL) {
+    atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "Memory not allocated for namespace list struct\n");
+    return -1;
+  }
+
+  memset(ns_list, 0, sizeof(atcommons_enroll_namespace_list_t));
+
+  return 0;
+}
+
 int atcommons_enroll_namespace_list_append(atcommons_enroll_namespace_list_t **ns_list,
                                            atcommons_enroll_namespace_t *ns) {
   if (ns == NULL) {
@@ -134,4 +145,4 @@ int atcommons_enroll_namespace_list_from_string(atcommons_enroll_namespace_list_
     pos += strlen(json_str + pos) + 1;
   }
   exit: { return ret; }
-}
+}