fix: do not overwrite ret value during tear down in functional tests

atsign-foundation · Dec 23, 2024 · fb8fb71 · fb8fb71
1 parent 7a0d22d
commit fb8fb71
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/tests/functional_tests/tests/test_atclient_monitor.c b/tests/functional_tests/tests/test_atclient_monitor.c
@@ -118,8 +118,7 @@ int main() {
 
   goto exit;
 exit: {
-  if ((ret = functional_tests_tear_down_sharedenckeys(&atclient1, ATKEY_SHAREDWITH)) != 0) {
-    ret = 1;
+  if ((functional_tests_tear_down_sharedenckeys(&atclient1, ATKEY_SHAREDWITH)) != 0) {
     atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "Failed to tear down sharedenckeys: %d\n", ret);
   }
   atclient_atkeys_free(&atkeys_sharedby);

diff --git a/tests/functional_tests/tests/test_atclient_notify.c b/tests/functional_tests/tests/test_atclient_notify.c
@@ -192,7 +192,7 @@ static int test_1_notify(atclient *atclient, char *notification_id) {
   goto exit;
 
 exit: {
-  if ((ret = functional_tests_tear_down_sharedenckeys(atclient, ATKEY_SHAREDWITH)) != 0) {
+  if (functional_tests_tear_down_sharedenckeys(atclient, ATKEY_SHAREDWITH) != 0) {
     atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "Failed to tear down sharedenckeys: %d\n", ret);
   }
   atclient_notify_params_free(&params);

diff --git a/tests/functional_tests/tests/test_atclient_sharedkey.c b/tests/functional_tests/tests/test_atclient_sharedkey.c
@@ -90,11 +90,9 @@ int main(int argc, char *argv[]) {
 
 exit: {
   if (functional_tests_tear_down_sharedenckeys(&atclient1, SECOND_ATSIGN) != 0) {
-    ret = 1;
     atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "tear_down: %d\n", ret);
   }
   if (functional_tests_tear_down_sharedenckeys(&atclient2, FIRST_ATSIGN) != 0) {
-    ret = 1;
     atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "tear_down: %d\n", ret);
   }
   atclient_free(&atclient1);