fix: update at_talk #292
Merged
fix: update at_talk #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I rewrote the entirety of at_talk in this PR: #281 with features like reconnection |
JeremyTubongbanua
approved these changes
Jun 6, 2024
|
We can merge this, and I can deal with the merge conflicts myself in my own PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Make sure the monitor has the proper contexts, and removed some logging that was happening when the monitor was empty.
- How I did it
- How to verify it
build atsdk
run
sudo sh run.sh -t @{atsign} -f @{atsign}- Description for the changelog
fix: update at_talk