Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check for ret <= 0 in atclient_monitor_read #295

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

JeremyTubongbanua
Copy link
Member

@JeremyTubongbanua JeremyTubongbanua commented Jun 6, 2024

- What I did

  • feat: pkam refactor and reconnection examples #281 fixed connection.c's atclient_connection_send's issue with ret == 0 as an error,
  • this PR also adds that same error handling in atclient_monitor_read.
  • this comment is a good explanation of why we should check for the mbedtls_ssl_read(...) == 0 case.

- How I did it

- How to verify it

  • at_talk works

- Description for the changelog
feat: check for ret <= 0 in atclient_monitor_read

@JeremyTubongbanua JeremyTubongbanua self-assigned this Jun 6, 2024
@JeremyTubongbanua JeremyTubongbanua marked this pull request as ready for review June 6, 2024 15:38
@JeremyTubongbanua JeremyTubongbanua merged commit 051c16c into trunk Jun 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants