Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup some tests #471

Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore: cleanup some tests #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions packages/atclient/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@

file(GLOB_RECURSE files ${CMAKE_CURRENT_LIST_DIR}/test_*.c)
foreach(file ${files})
# ${filename} - without `.c`
get_filename_component(filename ${file} NAME)
string(REPLACE ".c" "" filename ${filename})
# ${filename} - without `.c`
get_filename_component(filename ${file} NAME)
string(REPLACE ".c" "" filename ${filename})

add_executable(${filename} ${file})
target_link_libraries(${filename} PRIVATE atclient)
add_test(NAME ${filename} COMMAND $<TARGET_FILE:${filename}>)
endforeach()

add_executable(${filename} ${file})
target_link_libraries(${filename} PRIVATE atclient)
add_test(NAME ${filename} COMMAND $<TARGET_FILE:${filename}>)
endforeach()
2 changes: 1 addition & 1 deletion packages/atclient/tests/test_cjson.c → packages/atcommons/tests/test_cjson.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include <cJSON.h>
#include <atcommons/json.h>
#include <stddef.h> // IWYU pragma: keep
#include <stdio.h>

Expand Down
10 changes: 5 additions & 5 deletions tests/functional_tests/tests/test_atclient_notify.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,22 +219,22 @@ static int test_2_notify_long_text(atclient *atclient, char *notification_id) {
goto exit;
}

if((ret = atclient_notify_params_set_operation(&params, ATCLIENT_NOTIFY_OPERATION_UPDATE)) != 0) {
if ((ret = atclient_notify_params_set_operation(&params, ATCLIENT_NOTIFY_OPERATION_UPDATE)) != 0) {
atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "Failed to set operation: %d\n", ret);
goto exit;
}

if((ret = atclient_notify_params_set_atkey(&params, &atkey)) != 0) {
if ((ret = atclient_notify_params_set_atkey(&params, &atkey)) != 0) {
atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "Failed to set atkey: %d\n", ret);
goto exit;
}

if((ret = atclient_notify_params_set_value(&params, VERY_LONG_TEXT)) != 0) {
if ((ret = atclient_notify_params_set_value(&params, VERY_LONG_TEXT)) != 0) {
atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "Failed to set value: %d\n", ret);
goto exit;
}

if((ret = atclient_notify_params_set_should_encrypt(&params, true)) != 0) {
if ((ret = atclient_notify_params_set_should_encrypt(&params, true)) != 0) {
atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "Failed to set should_encrypt: %d\n", ret);
goto exit;
}
Expand All @@ -251,4 +251,4 @@ exit: {
atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_INFO, "test_2_notify_long_text End (%d)\n", ret);
return ret;
}
}
}
Loading