Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow client to configure the expiry on the OTP #1127

Closed
sitaram-kalluri opened this issue Sep 25, 2023 · 3 comments · Fixed by atsign-foundation/at_server#1609
Closed

Allow client to configure the expiry on the OTP #1127

sitaram-kalluri opened this issue Sep 25, 2023 · 3 comments · Fixed by atsign-foundation/at_server#1609
Assignees
@sitaram-kalluri
Labels
enhancement New feature or request

Comments

@sitaram-kalluri
Copy link
Member

sitaram-kalluri commented Sep 25, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

Currently the otp:get returns an OTP from the server. The expiry of the OTP lies with the server. Enhance the code for the client to optionally set the expiry for the opt:get

Describe the solution you'd like

Add an optional parameter to the "otp" verb to set the expiry limit.
@sitaram-kalluri sitaram-kalluri added the enhancement New feature or request label Sep 25, 2023
@sitaram-kalluri
Copy link
Member Author

The changes in at_commons are in: atsign-foundation/at_libraries#422
The changes in at_server are in: atsign-foundation/at_server#1598

@sitaram-kalluri sitaram-kalluri linked a pull request Oct 9, 2023 that will close this issue
feat: Implement OTP Store and enable client to set OTP expiry atsign-foundation/at_server#1598
Closed
@sitaram-kalluri
Copy link
Member Author

sitaram-kalluri commented Oct 16, 2023 •
edited
Loading

Code changes completed. Pending PR review and merging to trunk branch

@sitaram-kalluri sitaram-kalluri linked a pull request Oct 19, 2023 that will close this issue
fix: otp expires after use atsign-foundation/at_server#1594
Closed
@sitaram-kalluri sitaram-kalluri removed a link to a pull request Oct 19, 2023
fix: otp expires after use atsign-foundation/at_server#1594
Closed
@sitaram-kalluri sitaram-kalluri linked a pull request Oct 19, 2023 that will close this issue
feat: Persist OTPs in keystore and prevent reuse of OTPs atsign-foundation/at_server#1609
Merged
@sitaram-kalluri
Copy link
Member Author

The changes are merged to trunk and released into Canary 3.0.36b

@srieteja srieteja mentioned this issue Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sitaram-kalluri sitaram-kalluri

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@sitaram-kalluri