Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: otp expires after use #1594

Closed
wants to merge 10 commits into from
Closed

fix: otp expires after use #1594

wants to merge 10 commits into from

Conversation

srieteja
Copy link
Contributor

@srieteja srieteja commented Oct 4, 2023 •
edited
Loading

- What I did

  • Ensure that OTP expires after use and cannot be reused

- How I did it

  • Remove the OTP from cache after it is validated

- How to verify it

  • unit and functional tests added

- Description for the changelog

fix: ensure otp expires after use

@sitaram-kalluri sitaram-kalluri linked an issue Oct 19, 2023 that may be closed by this pull request
Allow client to configure the expiry on the OTP atsign-foundation/at_client_sdk#1127
Closed
@sitaram-kalluri sitaram-kalluri removed a link to an issue Oct 19, 2023
Allow client to configure the expiry on the OTP atsign-foundation/at_client_sdk#1127
Closed
@srieteja
Copy link
Contributor Author

This fix has been merged to trunk through atsign-foundation/at_client_sdk#1127

@srieteja srieteja closed this Oct 26, 2023
@sitaram-kalluri sitaram-kalluri deleted the otp_expires_after_use branch October 26, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitaram-kalluri sitaram-kalluri Awaiting requested review from sitaram-kalluri

@murali-shris murali-shris Awaiting requested review from murali-shris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@srieteja