Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Test websocket changes #1428

Draft
wants to merge 15 commits into
base: trunk
Choose a base branch
from
Draft

Conversation

purnimavenkatasubbu
Copy link
Member

@purnimavenkatasubbu purnimavenkatasubbu commented Nov 11, 2024

- What I did
Uptake of WebSocket changes from at_lookup in at_client.
- How I did it

  • Renamed from getSocket() to underlying
  • Added an optional parameter "atConnectionFactory" defaulted to SecureSocketFactory in the Remote secondary
  • Added an optional parameter "atConnectionFactory" in syncService, NotificationService, at_client_impl and monitor.dart and defaulted that to secureSocketFactory

- How to verify it

  • All the existing tests should pass
  • Added new functional test "at_lookup_socket_test" which tests WebSocketFactory and SecureSocketFactory.

- TODO

  • Refactor the existing at_functional_tests and at_end2end_tests to run with both securesocket and websocket changes.

- Description for the changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant