Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable user sharing #907

Merged
merged 4 commits into from
Mar 2, 2023
Merged

Conversation

sonle-geekyants
Copy link
Contributor

@sonle-geekyants sonle-geekyants commented Feb 3, 2023

- What I did

issue #459

- How I did it

  1. Write data
    On Windows, the biometric library is limited to 2560 characters per file.
    So when a String is too long, I will split it into a list of strings and save them in files one by one.
  2. Read data
    When reading data, I will count the total number of files and then merge the contents of the files together.

- How to verify it

Check the change code and run the app on Windows.

- Description for the changelog

@murali-shris
Copy link
Member

@sonle-geekyants please elaborate on the changes.sections how I did, how to verify ?
Please check the feasibility of writing unit tests to verify your code changes.

@sonle-geekyants
Copy link
Contributor Author

I've done the unit test and added the comment for the ticket. Could you please check it? @murali-shris

@gkc
Copy link
Contributor

gkc commented Feb 15, 2023

@murali-shris can you review this again please? @sonle-geekyants has made changes in response to your review

@murali-shris
Copy link
Member

I've done the unit test and added the comment for the ticket. Could you please check it? @murali-shris

@sonle-geekyants I don't see the unit tests. did you forget to commit ?

@sonle-geekyants
Copy link
Contributor Author

No, because my change is private function so I don't write the unit test for it. And I see that now, the unit tests are using functions that have my changes so I thought that if they passed my edits would be correct as well. @murali-shris @gkc

@murali-shris murali-shris changed the title Feature/enable user sharing feat: enable user sharing Mar 2, 2023
@murali-shris murali-shris merged commit 4d54bfb into trunk Mar 2, 2023
@murali-shris murali-shris deleted the feature/enable-user-sharing branch March 2, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants