Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding at_getting_started very simple examples in Dart #167

Merged
merged 6 commits into from
Jan 20, 2024

Conversation

cconstab
Copy link
Member

very simple atKey and notification examples as simple starting point

- What I did
Added simple (but powerful) examples to get people started with dart
- How I did it
Migrate code from my personal repo and added basic ReadMe and asciinema examples
- How to verify it
ran and recorded the results in the Readme
- Description for the changelog
Added pre starting examples using Dart and atKeys/Notifications.

@murali-shris
Copy link
Member

Reviewed. looks good to me

@cconstab cconstab requested a review from murali-shris January 20, 2024 11:08
@cconstab cconstab changed the title Adding at_getting_started: very simple examples in Dart Feat: Adding at_getting_started: very simple examples in Dart Jan 20, 2024
@cconstab cconstab changed the title Feat: Adding at_getting_started: very simple examples in Dart Feat: Adding at_getting_started very simple examples in Dart Jan 20, 2024
@cconstab cconstab changed the title Feat: Adding at_getting_started very simple examples in Dart feat: Adding at_getting_started very simple examples in Dart Jan 20, 2024
@cconstab
Copy link
Member Author

Reviewed. looks good to me

I resync with trunk so is fine to approve/merge TY

@cconstab
Copy link
Member Author

Reviewed. looks good to me

Could you approve for me?

@cconstab cconstab self-assigned this Jan 20, 2024
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkc gkc merged commit 356bbfd into trunk Jan 20, 2024
2 checks passed
@cconstab cconstab deleted the at_getting_started-colin branch January 20, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants