Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: organize demos #216

Merged
merged 5 commits into from
Aug 8, 2024
Merged

chore: organize demos #216

merged 5 commits into from
Aug 8, 2024

Conversation

XavierChanth
Copy link
Member

- What I did

  • Moved all demos into demos/
  • Moved at_demo_data into packages/

- How I did it

- How to verify it

- Description for the changelog
chore: organize demos

@XavierChanth XavierChanth requested a review from cpswan August 6, 2024 15:53
@XavierChanth XavierChanth force-pushed the xc-organize-demos branch 2 times, most recently from 8960772 to d46f00d Compare August 6, 2024 16:03
@cpswan
Copy link
Member

cpswan commented Aug 7, 2024

@XavierChanth is this ready to review now?

@XavierChanth
Copy link
Member Author

@XavierChanth is this ready to review now?

Yes it is

Copy link
Member

@cpswan cpswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but one change that looks accidental, and also mwc_demo/dart/iot_sender/bin/.set_hro2_receivers.dart.un~ shouldn't be there, so let's use this opportunity to get rid.

.github/workflows/static_analysis.yml Outdated Show resolved Hide resolved
@XavierChanth XavierChanth requested a review from cpswan August 8, 2024 14:33
@cpswan
Copy link
Member

cpswan commented Aug 8, 2024

@XavierChanth can we also lose the stray vim undo file at mwc_demo/dart/iot_sender/bin/.set_hro2_receivers.dart.un~

@XavierChanth
Copy link
Member Author

@XavierChanth can we also lose the stray vim undo file at mwc_demo/dart/iot_sender/bin/.set_hro2_receivers.dart.un~

That was a delete

@XavierChanth XavierChanth merged commit 96680bf into trunk Aug 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants