fix: Update KeysUtil.java #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyTubongbanua
previously requested changes
Nov 9, 2022
Good catch, updated accordingly |
gkc
reviewed
Nov 13, 2022
gkc
reviewed
Nov 13, 2022
gkc
reviewed
Nov 13, 2022
gkc
requested changes
Nov 13, 2022
There was a problem hiding this comment.
Not really sure I understand the code changes completely ...
I think logic we want is:
-
loadKeys
- check first if file exists at ~/.atsign/keys/$atSign_key.atKeys
- if it does, load it
- else
- check if file exists at ./keys/$atSign_key.atKeys
- If it does, load it but also log a warning saying "keys files found in deprecated location - please move to ~/.atsign/keys directory" or similar
-
saveKeys
- save file to ~/.atsign/keys/$atSign_key.atKeys and log an info message stating the same
|
@TylerTrott Lots of UMass students are using at_java for their Android Studio projects Another thing to consider is how the apps will access their .atKeys files |
|
We’ve done zero work so far on java sdk for storing keys in or getting keys
from the keychain
…On Tue, Nov 15, 2022 at 16:58 JeremyTubongbanua ***@***.***> wrote:
@TylerTrott <https://github.com/TylerTrott> Lots of UMass students are
using at_java for their Android Studio projects
Another thing to consider is how the apps will access their .atKeys files
—
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXNZL7ED5BQOYXKSRTGWLWIO6MJANCNFSM6AAAAAAR356NWE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
gkc
requested changes
Nov 18, 2022
gkc
requested changes
Dec 12, 2022
gkc
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Resolved issue #71
- How I did it
Change path
- How to verify it
Eyeball path, should be fine, nothing crazy
- Description for the changelog
Update Path for getKeysFile to look in ~/.atsign/keys